Remove feed signup link if licence finder

The plan is to remove the feed links from all finders, unless we gain
evidence that it is needed. Until this decision is made, we don't want to
introduce the feature for the new licence finder.

A new generalised method could be implented (not use
`is_licence_transaction?`) if we wanted to do this for a subset of
finders, vs all.

app/presenters/signup_links_presenter.rb

@@ -22,11 +22,15 @@ def email_signup_link
     signup_link = content_item.signup_link
     return signup_link if signup_link.present?
 
-    "#{content_item.email_alert_signup['base_path']}#{query_string(alert_query_params)}" if content_item.email_alert_signup
+    if content_item.email_alert_signup
+      "#{content_item.email_alert_signup['base_path']}#{query_string(alert_query_params)}"
+    end
   end
 
   def feed_link
-    "#{content_item.base_path}.atom#{query_string(alert_query_params.merge(keywords:))}"
+    unless content_item.is_licence_transaction?
+      "#{content_item.base_path}.atom#{query_string(alert_query_params.merge(keywords:))}"
+    end
   end
 
   def alert_query_params

app/views/finders/show.html.erb

@@ -4,7 +4,9 @@
   <% content_for :title, content_item.title %>
 <% end %>
 <% content_for :head do %>
-  <%= auto_discovery_link_tag(:atom, signup_links[:feed_link]) %>
+  <% if signup_links[:feed_link] %>
+    <%= auto_discovery_link_tag(:atom, signup_links[:feed_link]) %>
+  <% end %>
   <%= render 'finder_meta', content_item: content_item %>
 <% end %>
 

spec/presenters/signup_link_presenter_spec.rb

@@ -121,6 +121,20 @@
           expect(subject.signup_links[:feed_link]).to eql("/mosw-reports.atom?keywords=micropig&topic%5B%5D=hidden_facet_content_id")
         end
       end
+
+      context "with a licence transaction" do
+        let(:facet_values) do
+          []
+        end
+
+        before do
+          allow(content_item).to receive(:is_licence_transaction?).and_return(true)
+        end
+
+        it "returns nil" do
+          expect(subject.signup_links[:feed_link]).to be nil
+        end
+      end
     end
   end
 end