Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove subscribe to feed link for licence finder #3097

Merged
merged 4 commits into from
Jul 14, 2023

Commits on Jun 30, 2023

  1. Move licence finder check to model

    Allows us to check for the licence finder beyond the QueryBuilder class.
    The ContentItem model also seems a more appropriate place to verfiy the
    exact finder content item..
    1pretz1 committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    a45ed6b View commit details
    Browse the repository at this point in the history
  2. Remove feed signup link if licence finder

    The plan is to remove the feed links from all finders, unless we gain
    evidence that it is needed. Until this decision is made, we don't want to
    introduce the feature for the new licence finder.
    
    A new generalised method could be implented (not use
    `is_licence_transaction?`) if we wanted to do this for a subset of
    finders, vs all.
    1pretz1 committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    c9fccd5 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2023

  1. Make atomAutodiscoveryLink optional

    The `LiveSearch` module would not be initialised if $atomAutodiscoveryLink returns a falsey value.
    
    Since the subscribe to feed link is removed, this is now an optional argument in `application.js`. The `live_search.js` module is updated to check if `$atomAutodiscoveryLink` is set before trying to interact with it.
    MartinJJones committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    f9c845a View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Add tests to ensure live_search still works when atomAutodiscoveryL…

    …ink is set to null
    
    Since the `$atomAutodiscoveryLink` is now optional, we still want to ensure that all of the existing functionality works as expected.
    MartinJJones committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    7055349 View commit details
    Browse the repository at this point in the history