Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scrolltracker reset event #3129

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Conversation

andysellick
Copy link
Contributor

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

What / why

Adds a dynamic page update event (custom event) into the bit of the search code where the page is dynamically updated.

If listening, the scroll tracker will detect this event and reset scroll tracking.

See related PR: alphagov/govuk_publishing_components#3544

Visual changes

None.

Trello card: https://trello.com/c/fhnLqnKw/669-scroll-tracker-to-refresh-on-dynamic-pages

- if listening, the scroll tracker will detect this event and reset scroll tracking
- see related PR: alphagov/govuk_publishing_components#3544
@govuk-ci govuk-ci temporarily deployed to finder-frontend-pr-3129 August 10, 2023 10:11 Inactive
Copy link
Contributor

@JamesCGDS JamesCGDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@andysellick andysellick merged commit 71d6dc1 into main Aug 11, 2023
8 checks passed
@andysellick andysellick deleted the add-scrolltracker-reset-event branch August 11, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants