Revert "Add signup links index to data_attributes" #3218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- set-indexes attempts to automatically calculate and set the indexes on links using JavaScript. Since we no longer need the indexes this is unnecessary
andysellick
force-pushed
the
revert-3140-fix_subscription_links_index
branch
from
da1e1e7
to
56dbf48
Compare
AshGDS
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Reverts #3140
Why
This was some quite complex code to ensure that the values for indexes for GA4 tracking were correct on the 'Get emails' and 'Subscribe to feed' links at the top and bottom of search results. The top two were supposed to have an index of 1 and 2, and the bottom two had to have 3 and 4.
The problem was that sometimes only one of these links was visible, so the indexes had to account for that - the top link would be index 1, the bottom link index 2.
This was all fine until we realised that on mobile the links at the top are always hidden, using CSS. Since we can't know the size of the user viewport when rendering the page (without some additional and probably nasty JS) the decision was made to remove the index values entirely a the links already have information that shows whether they're at the top or the bottom.
Visual changes
None.
Trello card: https://trello.com/c/qALJdYg1/722-amend-index-on-mobile-view-of-subscribe-to-rss-feed-link