-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ga4 tracking for filter/sorting UI interaction #3485
Changes from all commits
fb7ef7a
cd73e83
a500e8e
29187a9
d21d6bd
4726c45
400360d
4400c48
cced2fc
030e35e
3fe3971
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,8 +5,10 @@ | |
id: "facet_taxon_#{taxon_facet.key}", | ||
index_section: index, | ||
index_section_count: count, | ||
data_attributes: { "ga4-index": { index_section: index + 1, index_section_count: count } }, | ||
change_category: "update-filter select", | ||
classes: "js-all-content-finder-taxonomy-select" | ||
} do %> | ||
<div class="js-all-content-finder-taxonomy-select" data-ga4-change-category="update-filter select" data-ga4-section="Topic"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We need to keep the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. there was a reason i did this at some point and i did indeed mean to put that class the the container but must have got distracted! so the class is on the component now as that div seems uneccessary |
||
<%= render "govuk_publishing_components/components/select", { | ||
id: 'level_one_taxon', | ||
label: "Topic", | ||
|
@@ -22,5 +24,4 @@ | |
options: taxon_facet.sub_topics | ||
} %> | ||
</div> | ||
</div> | ||
<% end %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self (@csutter): Not necessarily one for right now, but perhaps with the above code dealing with the new all content finder too, maybe it's worth creating a
GOVUK.AllContentFinder
module to not litter the application.js too much.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes i was thinking to put this in a more isolated place than here but was in 2 minds about a few places where exactly. so I have left as is for the purposes of this PR, but agreed its a bit lazy just whacking it here in the long run