All content finder: Implement filter section status text #3489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes tests for those facets where we have implemented `#applied_filters`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the filter sections' status text, which shows the number of selected filters (or the currently selected non-default sort option in the case of the sort facet) for every facet/filter section in the new all content finder's filter panel.
Review app example link with lots of selected filters
https://finder-frontend-pr-3489.herokuapp.com/search/all?keywords=&order=updated-newest&level_one_taxon=495afdb6-47be-4df1-8b38-91c8adb1eefc&level_two_taxon=13fb7519-c48e-4577-90f8-aaf483fa0c03&content_purpose_supergroup%5B%5D=services&content_purpose_supergroup%5B%5D=guidance_and_regulation&content_purpose_supergroup%5B%5D=news_and_communications&content_purpose_supergroup%5B%5D=research_and_statistics&content_purpose_supergroup%5B%5D=policy_and_engagement&content_purpose_supergroup%5B%5D=transparency&public_timestamp%5Bfrom%5D=2005&public_timestamp%5Bto%5D=2012&commit=Apply+filters
Visual changes