New "all content" finder UI tweaks #3495
Draft
+89
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This causes the button's text to be added to the query parameters, which we don't need and clutters up the analytics.
- Move overall UI (except breadcrumbs) into a `app-all-content-finder` container - Add margin to container on tablet+
This needs to be made more resilient for Safari (and some older browsers) by targeting the marker's (triangle) pseudo-element.
This turned out to be a nasty Webkit bug, which generally seems to be poor at dealing with text-decoration-thickness.
- Inline spelling suggestion code from old UI partial - Add wrapper div with appropriate margins
This removes the separate page heading, and uses the variant of the `search` component that comes with a heading-wrapped label instead to avoid duplication.
- Reduce margin between heading and "pills" - Increase gap between "pills" - Increase bottom padding of component
This still creates a mildly jarring change at 770px but makes things look nicer on _some_ portrait orientation tablets (iPad is still too wide to get tablet breakpoint).
There's a `govuk-width-container` within another one, which is unnecessary and causes display issues at some breakpoints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes an assortment of minor design tweaks to the new UI for the "all content" finder after a design review.
Before
After