Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update file upload content #1712

Merged
merged 6 commits into from
Jan 17, 2025
Merged

Update file upload content #1712

merged 6 commits into from
Jan 17, 2025

Conversation

jamie-o-wilkinson
Copy link
Contributor

@jamie-o-wilkinson jamie-o-wilkinson commented Jan 16, 2025

What problem does this pull request solve?

Trello card: https://trello.com/c/gg7uqjma/2069-update-content-in-production-for-muscle-version-v2

Adds file upload specific content to the edit question page when the answer type is "File upload". We still need to update the error messages for the question text field to match the new label, but this will be done in a subsequent PR.

Adds additional information about file upload questions at the top of the page.

Removes the ability to specify that the question can be answered more than once, as this is not currently supported for file upload questions.

Screenshot 2025-01-17 at 12 58 13

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Has all relevant documentation been updated?

@stephencdaly stephencdaly marked this pull request as ready for review January 17, 2025 12:32
Copy link
Contributor

@DavidBiddle DavidBiddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and I can see the changes working locally 🎉

jamie-o-wilkinson and others added 6 commits January 17, 2025 12:59
As we have for the hint text on the various fields on the edit
question page, add a helper to get the text for the label for the
question text input depending on the answer type. Currently, we only
have different text for the `file` answer type.
@stephencdaly stephencdaly force-pushed the update-file-upload-content branch from e5f4352 to d95fc0d Compare January 17, 2025 12:59
Copy link

@stephencdaly stephencdaly merged commit c7f9f4b into main Jan 17, 2025
4 checks passed
@stephencdaly stephencdaly deleted the update-file-upload-content branch January 17, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants