Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update progress block #4413

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Update progress block #4413

wants to merge 7 commits into from

Conversation

JamesCGDS
Copy link
Contributor

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

What

Rework progress block.

Why

Trello card

@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-4413 November 18, 2024 19:10 Inactive
@JamesCGDS JamesCGDS force-pushed the update_progress_block branch from 11680fd to 86a0f0f Compare November 19, 2024 17:21
@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-4413 November 19, 2024 17:21 Inactive
For the 3 boxes that appear, I've assumed that only 3 would be displayed and therefore I've used the nth-child() selector to apply the necessary colours. I'm not sure if this is too brittle an approach, however, so happy to discuss.
@JamesCGDS JamesCGDS force-pushed the update_progress_block branch from 86a0f0f to 84113ef Compare November 20, 2024 10:31
@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-4413 November 20, 2024 10:31 Inactive
@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-4413 November 20, 2024 10:36 Inactive
@JamesCGDS
Copy link
Contributor Author

This PR has been superseded by #4421 but we'll retain this for now as it contains some code that might be useful in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants