Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rspec rubocop #4524

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Rspec rubocop #4524

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
9238dbf
configure rubocop for rspec
KludgeKML Dec 11, 2024
cd6324a
run rubocop --autocorrect
KludgeKML Dec 11, 2024
6dab178
Run rubocop -A
KludgeKML Dec 11, 2024
54ad64c
Fix tests broken by rubocop -A
KludgeKML Dec 12, 2024
e8c538d
Fix lints in spec/components
KludgeKML Dec 12, 2024
d28abf6
lint: fix spec/helpers
KludgeKML Dec 12, 2024
e4517a5
lint: fix spec/models
KludgeKML Dec 12, 2024
b64750f
lint: fix spec/presenters
KludgeKML Dec 12, 2024
ef97c27
Convert method to matcher
KludgeKML Dec 16, 2024
c748cf7
lint: fix spec/requests
KludgeKML Dec 16, 2024
bf30659
lint: fix spec/requests added
KludgeKML Dec 16, 2024
fb14dd6
lint: fix spec/routing
KludgeKML Dec 16, 2024
5cace6c
lint: fix spec/support
KludgeKML Dec 16, 2024
25ad2a9
lint: fix spec/system
KludgeKML Dec 16, 2024
e4a8bf8
lint: fix spec/unit/presenters
KludgeKML Dec 16, 2024
d5a1904
lint: fix spec/unit/services
KludgeKML Dec 16, 2024
7f7901d
lint: fix spec/unit/simple_smart_answers
KludgeKML Dec 16, 2024
13895bb
lint: fix spec/unit/calendar
KludgeKML Dec 16, 2024
dd5e5d0
lint: fix spec/unit/sanitiser
KludgeKML Dec 16, 2024
eee8251
lint: fix spec/unit
KludgeKML Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
248 changes: 122 additions & 126 deletions spec/unit/simple_smart_answers/flow_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,141 +1,137 @@
module SimpleSmartAnswers
RSpec.describe Flow do
context "finding nodes" do
before do
@nodes = [
{
"kind" => "question",
"slug" => "question-1",
"title" => "Question 1",
"body" => "<p>This is question 1</p>",
"options" => [],
},
{
"kind" => "question",
"slug" => "question-2",
"title" => "Question 2",
"body" => "<p>This is question 2</p>",
"options" => [],
},
{
"kind" => "outcome",
"slug" => "outcome-1",
"title" => "Outcome 1",
"body" => "<p>This is outcome 1</p>",
},
{
"kind" => "outcome",
"slug" => "outcome-1",
"title" => "Outcome 1",
"body" => "<p>This is outcome 1</p>",
},
]
@flow = described_class.new(@nodes)
end
RSpec.describe SimpleSmartAnswers::Flow do
subject(:flow) { described_class.new(nodes) }

it "returns the node matching the slug" do
node = @flow.node_for_slug("question-2")
context "when finding nodes" do
let(:nodes) do
[
{
"kind" => "question",
"slug" => "question-1",
"title" => "Question 1",
"body" => "<p>This is question 1</p>",
"options" => [],
},
{
"kind" => "question",
"slug" => "question-2",
"title" => "Question 2",
"body" => "<p>This is question 2</p>",
"options" => [],
},
{
"kind" => "outcome",
"slug" => "outcome-1",
"title" => "Outcome 1",
"body" => "<p>This is outcome 1</p>",
},
{
"kind" => "outcome",
"slug" => "outcome-1",
"title" => "Outcome 1",
"body" => "<p>This is outcome 1</p>",
Comment on lines +28 to +31
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's strange that Outcome 1 is duplicated. Perhaps it can be deleted?

},
]
end

it "returns the node matching the slug" do
node = flow.node_for_slug("question-2")

expect(node).to be_a(Node)
expect(node.title).to eq("Question 2")
end
expect(node).to be_a(SimpleSmartAnswers::Node)
expect(node.title).to eq("Question 2")
end

it "returns nil if none match" do
expect(@flow.node_for_slug("question-3")).to be_nil
end
it "returns nil if none match" do
expect(flow.node_for_slug("question-3")).to be_nil
end

it "returns the first node as the start_node" do
node = @flow.start_node
it "returns the first node as the start_node" do
node = flow.start_node

expect(node).to be_a(Node)
expect(node.title).to eq("Question 1")
end
expect(node).to be_a(SimpleSmartAnswers::Node)
expect(node.title).to eq("Question 1")
end
end

describe "#state_for_responses" do
before do
@flow =
described_class.new(
[
{
"kind" => "question",
"slug" => "question-1",
"title" => "Question 1",
"body" => "<p>This is question 1</p>",
"options" => [
{
"label" => "Option 1",
"slug" => "option-1",
"next_node" => "question-2",
},
{
"label" => "Option 2",
"slug" => "option-2",
"next_node" => "outcome-1",
},
{
"label" => "Option 3",
"slug" => "option-3",
"next_node" => "outcome-2",
},
],
},
{
"kind" => "question",
"slug" => "question-2",
"title" => "Question 2",
"body" => "<p>This is question 2</p>",
"options" => [
{
"label" => "Option 1",
"slug" => "option-1",
"next_node" => "outcome-1",
},
{
"label" => "Option 2",
"slug" => "option-2",
"next_node" => "outcome-2",
},
],
},
{
"kind" => "outcome",
"slug" => "outcome-1",
"title" => "Outcome 1",
"body" => "<p>This is outcome 1</p>",
},
{
"kind" => "outcome",
"slug" => "outcome-2",
"title" => "Outcome 2",
"body" => "<p>This is outcome 2</p>",
},
],
)
end
describe "#state_for_responses" do
let(:nodes) do
[
{
"kind" => "question",
"slug" => "question-1",
"title" => "Question 1",
"body" => "<p>This is question 1</p>",
"options" => [
{
"label" => "Option 1",
"slug" => "option-1",
"next_node" => "question-2",
},
{
"label" => "Option 2",
"slug" => "option-2",
"next_node" => "outcome-1",
},
{
"label" => "Option 3",
"slug" => "option-3",
"next_node" => "outcome-2",
},
],
},
{
"kind" => "question",
"slug" => "question-2",
"title" => "Question 2",
"body" => "<p>This is question 2</p>",
"options" => [
{
"label" => "Option 1",
"slug" => "option-1",
"next_node" => "outcome-1",
},
{
"label" => "Option 2",
"slug" => "option-2",
"next_node" => "outcome-2",
},
],
},
{
"kind" => "outcome",
"slug" => "outcome-1",
"title" => "Outcome 1",
"body" => "<p>This is outcome 1</p>",
},
{
"kind" => "outcome",
"slug" => "outcome-2",
"title" => "Outcome 2",
"body" => "<p>This is outcome 2</p>",
},
]
end

it "returns a state for the given responses" do
state = @flow.state_for_responses(%w[option-1])
it "returns a state for the given responses" do
state = flow.state_for_responses(%w[option-1])

expect(state.current_node.slug).to eq("question-2")
expect(state.current_question_number).to eq(2)
expect(state.completed_questions.size).to eq(1)
expect(state.current_node.slug).to eq("question-2")
expect(state.current_question_number).to eq(2)
expect(state.completed_questions.size).to eq(1)

answer1 = state.completed_questions.first
expect(answer1.label).to eq("Option 1")
expect(answer1.slug).to eq("option-1")
expect(answer1.question.title).to eq("Question 1")
end
answer1 = state.completed_questions.first
expect(answer1.label).to eq("Option 1")
expect(answer1.slug).to eq("option-1")
expect(answer1.question.title).to eq("Question 1")
end

it "stops processing and set error flag on invalid response" do
state = @flow.state_for_responses(%w[option-1 fooey option-2])
it "stops processing and set error flag on invalid response" do
state = flow.state_for_responses(%w[option-1 fooey option-2])

expect(state.error?).to be true
expect(state.current_node.slug).to eq("question-2")
expect(state.current_question_number).to eq(2)
expect(state.completed_questions.size).to eq(1)
expect(state.completed_questions.first.slug).to eq("option-1")
end
expect(state.error?).to be true
expect(state.current_node.slug).to eq("question-2")
expect(state.current_question_number).to eq(2)
expect(state.completed_questions.size).to eq(1)
expect(state.completed_questions.first.slug).to eq("option-1")
end
end
end
Loading