Add GA4 tracking to some missions page blocks #4534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshGDS
force-pushed
the
ga4-missions-pages
branch
from
2e1fc41 to
98fe48a
Compare
AshGDS
changed the title
AshGDS
changed the title
andysellick
reviewed
Dec 16, 2024
AshGDS
force-pushed
the
ga4-missions-pages
branch
from
4affa9c to
658160e
Compare
We need to set indexes on each box even though they are defined separately in the code. We also need to preserve the columns layout, so creating a container around all the boxes and taking advatnage of the JS index setting function in our GA4 code seemed most logical
AshGDS
force-pushed
the
ga4-missions-pages
branch
from
658160e to
0b7ed1d
Compare
Fix select content typo Use each_with_index
AshGDS
force-pushed
the
ga4-missions-pages
branch
from
0b7ed1d to
ba1308b
Compare
|
Thanks @andysellick - should be ready to re-review. Also had to rebase as the organisation logo's render statement moved to a new template. |
AshGDS
force-pushed
the
ga4-missions-pages
branch
from
d935ae7 to
4d52de5
Compare
AshGDS
force-pushed
the
ga4-missions-pages
branch
from
4d52de5 to
9c36fd6
Compare
|
Thanks @andysellick - should be ready to review again 👍 |
andysellick
reviewed
Dec 19, 2024
| ga4_track_links_only: "", | ||
| ga4_link: { | ||
| event_name: "navigation", | ||
| seciton: "Header", |
| @@ -382,6 +382,7 @@ Note that the `[Image: desktop.png]` syntax must be wrapped in quotes (`"[Image: | |||
| Layout blocks are similar to compound blocks in that they contain nested blocks. They are used to arrange blocks on the page, and to make it easier to apply styling to the blocks. | |||
|
|
|||
| - [Blocks Container](#blocks-container) | |||
| - [Box Container](#box-container) | |||
There was a problem hiding this comment.
Presumably this documentation can be removed now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / Why
<div>so the indexes could be set. Therefore there's a newbox_containerblock. (I didn't want to add the tracking on to the existingcolumns_layout<div>that surrounds all of them already, as I don't thinkcolumns_layoutshould have any tracking on it.)