Remove redundant CSS for organisation logo on landing page #4549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
reviewed
Jan 6, 2025
matthillco
force-pushed
the
remove-org-logo-override-css
branch
from
033a0de to
4ffceac
Compare
matthillco
force-pushed
the
remove-org-logo-override-css
branch
from
4ffceac to
9d08fb5
Compare
matthillco
force-pushed
the
remove-org-logo-override-css
branch
from
9d08fb5 to
2ca582c
Compare
matthillco
force-pushed
the
remove-org-logo-override-css
branch
from
2ca582c to
c81a2f2
Compare
andysellick
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove redundant CSS for the organisation logo on landing pages: this is now handled by a variant option in the gem component. Trello
Why
On the new Missions landing page served by the frontend app, the organisation logo in the header has the underline removed. This was achieved using some localised override CSS, which is against our principle of component isolation.