Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rails 8 upgrade #4556

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Rails 8 upgrade #4556

merged 3 commits into from
Jan 7, 2025

Conversation

unoduetre
Copy link
Contributor

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

What

Update our apps to run Rails 8

Why

To keep our apps up to date and using the latest software to include bug fixes and security updates.

Trello ticket

@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-4556 December 27, 2024 13:58 Inactive
@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-4556 December 27, 2024 16:22 Inactive
@unoduetre unoduetre mentioned this pull request Dec 31, 2024
Merged
@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-4556 December 31, 2024 10:09 Inactive
@unoduetre unoduetre marked this pull request as ready for review December 31, 2024 10:31
hannako
hannako reviewed Jan 6, 2025
View reviewed changes
Copy link
Contributor

@hannako hannako left a comment •
edited by unoduetre
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - have you tested it on integration?

@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-4556 January 6, 2025 16:52 Inactive
@unoduetre
Copy link
Contributor Author

Looks good - have you tested it on integration?

Yes. I let it run for a day there and on staging as well.

@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-4556 January 7, 2025 09:47 Inactive
@unoduetre unoduetre merged commit 0a4e41d into main Jan 7, 2025
12 checks passed
@unoduetre unoduetre deleted the rails-8-upgrade branch January 7, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannako hannako hannako approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@unoduetre @hannako @govuk-ci