Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete app projects #1823

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Remove obsolete app projects #1823

merged 2 commits into from
Mar 6, 2024

Conversation

samsimpson1
Copy link
Member

The resources in these projects have either already been deleted or are on a list to be removed in the future.

alphagov/govuk-infrastructure#1127

Copy link
Contributor

@sengi sengi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks so much for sorting through all this old cruft!

Spotted a couple of resources that I think we don't wanna delete (but still fine to delete the TF — we can just import those one or two things into govuk-infrastructure somewhere — just pointing 'em out so we don't delete the actual objects)

private_zone = true
}

resource "aws_efs_file_system" "assets-efs-fs" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the EFS filer that we're still using for temporarily storing uploaded attachments while they're scanned with Clam? Might need to remember to import it somewhere afterwards :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, I thought we were using a new efs volume for this but turns out it's still using the old one. I'll put it on the list of things that need moving across

}
}

resource "aws_docdb_cluster" "cluster" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one's still in use too so gonna need to import it somewhere at some point.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, this needs adding to the list too. When I looked on the AWS dashboard earlier it wasn't showing any documentdb clusters. Odd

@samsimpson1 samsimpson1 merged commit 2c18f7c into main Mar 6, 2024
2 checks passed
@samsimpson1 samsimpson1 deleted the samsimpson1/cleanup branch March 6, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants