This repository has been archived by the owner on Sep 5, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leenagupte
approved these changes
Jul 3, 2023
sihugh
reviewed
Jul 4, 2023
--- | ||
A: 1 | ||
B: 1 | ||
Z: 98 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be:
A: 50
B: 50
with no Z? Can chat off-thread
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Simon explained I need to remove the Z as it is only needed in the rendering app config, not the CDN config because A or B need to be assigned by the CDN.
@@ -7,3 +7,4 @@ | |||
--- | |||
Example: 86400 | |||
BankHolidaysTest: 86400 | |||
EsSixPointSeven: 604800 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a week 👍
Rosa-Fox
force-pushed
the
es-6.7-aa-test-config
branch
from
July 4, 2023 09:25
ec22f49
to
458c16b
Compare
The purpose of the A/A test is to test the % of allocation of traffic/sample population based on the current version of elastic (6.7) against itself. A (ES 6.7) vs A (ES6.7). The A/A is solely to identify how the approach allocates traffic. This will provide benchmark data to aid analysis in future AA tests. Rendering app PR: alphagov/finder-frontend#3053
Rosa-Fox
force-pushed
the
es-6.7-aa-test-config
branch
2 times, most recently
from
July 13, 2023 15:38
8902ac0
to
bfcf783
Compare
Rosa-Fox
force-pushed
the
es-6.7-aa-test-config
branch
from
July 13, 2023 15:40
bfcf783
to
e4740da
Compare
samsimpson1
added a commit
to alphagov/govuk-fastly
that referenced
this pull request
Jul 21, 2023
Rosa-Fox
added a commit
that referenced
this pull request
Jul 27, 2023
Removing AA test config as the test has expired. PR to implement the test: #463
Rosa-Fox
added a commit
that referenced
this pull request
Aug 16, 2023
[We recently ran an AA test for the Search team](#463). We are going to run it again, hence reinstating it in this PR! The purpose of the A/A test is to test the % of allocation of traffic/sample population based on the current version of elastic (6.7) against itself. A (ES 6.7) vs A (ES6.7). The A/A is solely to identify how the approach allocates traffic. This will provide benchmark data to aid analysis in future AA tests. This time around, the code will stay the same. We will use the same custom dimension and the variant split will still be 50/50. The only difference is that the custom dimension has been scoped as ‘user' as opposed to ‘session’ like it was last time. Scoping the custom dimension has already been done by a performance analyst. We plan to deploy this on Thursday 17 August for 1 week.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello
The purpose of the A/A test is to test the % of allocation of traffic/sample population based on the current version of Elastic Search (6.7) against itself. A (ES 6.7) vs A (ES6.7). The A/A is solely to identify how the approach allocates traffic. This will provide benchmark data to aid analysis in future AA tests.
Corresponding rendering app PR