Add worker to Content Publisher dependencies and remove e2e stack #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since alphagov/content-publisher#1522 was introduced Content Publisher has required a worker to operate normally. Because of this it is now added as an app dependency.
After chatting with Ben it sounds like we don't think that anyone uses this stack and adds an extra layer of complication for the dependencies of the worker as this would need an app and e2e equivalent. Thus it seems simpler to remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to reflect the changes introduced in alphagov/content-publisher#1522 where a worker was a necessary part of Content Publisher development.