Remove deny list logic from DGU #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those are new directives added during a migration to TF Cloud however it requires access to values in https://github.com/alphagov/govuk-fastly-secrets/blob/main/dictionaries.yaml and caused an error on apply: "Undefined `table ip_address_denylist`" It can be added once the existing config has been successful ported.
deborahchua
approved these changes
Jan 29, 2024
MuriloDalRi
added a commit
that referenced
this pull request
Apr 25, 2024
This was removed in #58 and can now be added back. https://trello.com/c/Oiai95mm/3458-enable-ja3-fingerprinting-for-dgu-3
MuriloDalRi
added a commit
that referenced
this pull request
Apr 26, 2024
This was removed in #58 and can now be added back. https://trello.com/c/Oiai95mm/3458-enable-ja3-fingerprinting-for-dgu-3
MuriloDalRi
added a commit
that referenced
this pull request
Apr 26, 2024
This was removed in #58 and can now be added back. https://trello.com/c/Oiai95mm/3458-enable-ja3-fingerprinting-for-dgu-3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those are new directives added during a migration to TF Cloud however it requires access to values in
https://github.com/alphagov/govuk-fastly-secrets/blob/main/dictionaries.yaml and caused an error on apply: "Undefined
table ip_address_denylist"It can be added once the existing config has been successful ported.