Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] DAC accessibility examples #3503

Closed
wants to merge 204 commits into from
Closed

Conversation

CharlotteDowns
Copy link
Contributor

@CharlotteDowns CharlotteDowns commented Apr 14, 2023

This is an example of what we want to have in the Frontend Review App to take to the Digital Accessibility Centre for an Audit.

This pull request is not intended to be merged into main

We need to add examples for:

  • Step-by-step
  • Task list (Using PR Task list component #2261 )
  • Check a phone number from the gov.uk account team
  • Header with menu variant
  • Input with a prefix or suffix (or both)
  • Small checkboxes
  • Small radios
  • 'Success' notification banner

We need to improve the full-page-examples page to include the other examples and a scenario for each if applicable.

For reviewers

Areas that explicitly need a review:

General review

  • Any updates to Exit this page component
  • Whether examples match those in the Design System patterns including: error states

Content and design review

  • Choice of content in examples
  • Reviewing the scenario examples in the example index files

Code review

  • Downsizing the commit history
  • Proper use of ARIA, as prescribed for the individual components
  • General correctness of code
  • Validation and posting
  • Adherence to HTML spec
  • Proper use of nunjucks and correct use of the various available variables

frankieroberto and others added 30 commits June 24, 2021 11:53
Think this is more consistent with how the Summary List component works.
Pending outcome of review of Tag display
The IDs were initially hardcoded, but are now dynamic, to avoid having duplicate IDs.
Whilst some existing components use rows and others use items, 'items' is more generic, and is closer to the HTML tag name ("list item") and the class name (`govuk-task-list__item`).
Think this can be smaller, in line with the existing Task List components in use in the wild.
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3503 April 26, 2023 13:15 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3503 April 26, 2023 13:29 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3503 April 26, 2023 15:14 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3503 April 26, 2023 21:24 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3503 May 3, 2023 10:02 Inactive
@querkmachine
Copy link
Member

Some more suggestions for consistency:

Tweak some classes for consistency with the versions in the Design System documentation
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3503 May 3, 2023 12:52 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3503 May 3, 2023 15:33 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3503 May 3, 2023 15:35 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3503 May 3, 2023 15:43 Inactive
@owenatgov
Copy link
Contributor

Closing as we're done with DAC auditing for the mo

@owenatgov owenatgov closed this Feb 9, 2024
@CharlotteDowns CharlotteDowns reopened this Jun 5, 2024
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3503 June 5, 2024 11:19 Inactive
@CharlotteDowns
Copy link
Contributor Author

CharlotteDowns commented Jun 5, 2024

Reopening as we are gearing up for a retest.

Here is a spreadsheet of the results from the last audit. It contains reference to which examples need to change for retest (column L, type: Example and Prototype fix).

We need to add or change these examples to include:

  • Password input
  • Navigation, updated Header and new Service header navigation components

Examples that don't need to be retested:

'Other' examples that don't need to be retested:

@CharlotteDowns
Copy link
Contributor Author

Examples that are different between this pull request and one of the latest pull requests of the review app #5046

@querkmachine
Copy link
Member

Retests were done against a new PR: #5088. I think this one is safe to close off again now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants