Update init containers to be PSS compliant in the apps namespace #2620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nimalank7
force-pushed
the
update-init-containers-PSS-compliant
branch
3 times, most recently
from
c012fe1 to
f124433
Compare
nimalank7
changed the title
nimalank7
force-pushed
the
update-init-containers-PSS-compliant
branch
from
f124433 to
be33f41
Compare
| capabilities: | ||
| drop: ["ALL"] | ||
| drop: {{ .Values.securityContext.capabilities.drop }} |
There was a problem hiding this comment.
Why do we need to read these in as Values?
There was a problem hiding this comment.
No particular reason. Mostly just being consistent with extracting everything out to values.
There was a problem hiding this comment.
If we're not changing it (and we wanna actually enforce this value anyway) - there's no need to have it as a variable. Just adds complexity to the configuration.
There was a problem hiding this comment.
Yep that's fair. I've pushed up now!
Description: - Enforce initContainers in the `app` namespace to be compliant when PSS is set to [restricted](https://kubernetes.io/docs/concepts/security/pod-security-standards/) - Tested in integration and observed that `content-data-admin` initContainers were starting properly - `govuk-mirror-sync-cronjob` can't be tested in integration as this has no mirrors so the PR will have to be merged and we will have to manually inspect staging ot see if it succeeds. - As part of #1883 - Paired with @MahmudH
nimalank7
force-pushed
the
update-init-containers-PSS-compliant
branch
from
be33f41 to
6eb6ac4
Compare
theseanything
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
appnamespace to be compliant when PSS is set to restrictedcontent-data-admininitContainers were starting properlygovuk-mirror-sync-cronjobcan't be tested in integration as this has no mirrors so the PR will have to be merged and we will have to manually inspect staging ot see if it succeeds.