Import database backup buckets from govuk-aws and small GCP changes #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r in GCP credentials var sets
sengi
approved these changes
Apr 25, 2024
Comment on lines
4
to
6
| "production" = "govuk-production-database-backups-replica" | ||
| "staging" = "govuk-production-database-backups" | ||
| "integration" = "govuk-staging-database-backups" |
There was a problem hiding this comment.
optional/trivial: can drop some unnecessary quotes here (dunno why tf fmt doesn't deal with this automatically 🤷)
Suggested change
| "production" = "govuk-production-database-backups-replica" | |
| "staging" = "govuk-production-database-backups" | |
| "integration" = "govuk-staging-database-backups" | |
| production = "govuk-production-database-backups-replica" | |
| staging = "govuk-production-database-backups" | |
| integration = "govuk-staging-database-backups" |
Imported from infra-database-backups-bucket
samsimpson1
force-pushed
the
samsimpson1/big-import
branch
from
973ad49 to
4f451dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCP changes won't work properly until the staging project is sorted out
#1127