Manage licensify documentdb clusters #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsimpson1
force-pushed
the
samsimpson1/i
branch
3 times, most recently
from
43855e8 to
5e57230
Compare
theseanything
approved these changes
Jul 25, 2024
| count = var.licensify_documentdb_instance_count | ||
| identifier = "licensify-documentdb-${count.index}" | ||
| cluster_identifier = aws_docdb_cluster.licensify_cluster.id | ||
| # TODO: make sure this is the right DB instance size |
There was a problem hiding this comment.
Is this copy pasta? Or do we still need to do this?
There was a problem hiding this comment.
It is copied from govuk-aws, I have no idea if we still need to do this though. It would probably be worth going around all of these instances at some point and making sure they are all the right size
samsimpson1
force-pushed
the
samsimpson1/i
branch
from
5e57230 to
2633076
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imported from app-licensify-documentdb in govuk-aws
The root password will be manually imported before applying.
#1127