Merge pull request #4273 from alphagov/remove-modernizr

Remove Modernizr
alphagov · Oct 3, 2024 · 659e2c4 · 659e2c4
2 parents 983d83b + 6ef0ea1
commit 659e2c4
Show file tree

Hide file tree

Showing 6 changed files with 1 addition and 10 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,7 @@
 
 ## Unreleased
 
+* **BREAKING:** Remove Modernizr ([PR #4273](https://github.com/alphagov/govuk_publishing_components/pull/4273))
 * Update accessibility criteria in component docs ([PR #4242](https://github.com/alphagov/govuk_publishing_components/pull/4242))
 * Show all big_number symbol types in our docs ([PR #4271](https://github.com/alphagov/govuk_publishing_components/pull/4271))
 * Remove incorrect search component example ([PR #4253](https://github.com/alphagov/govuk_publishing_components/pull/4253))

diff --git a/app/assets/config/govuk_publishing_components_manifest.js b/app/assets/config/govuk_publishing_components_manifest.js
@@ -8,6 +8,5 @@
 //= link_directory ../javascripts/govuk_publishing_components
 
 // Pre-compile these specific files
-//= link govuk_publishing_components/vendor/modernizr.js
 //= link govuk_publishing_components/vendor/lux/lux-reporter.js
 //= link govuk_publishing_components/vendor/lux/lux-measurer.js
diff --git a/app/assets/javascripts/govuk_publishing_components/vendor/modernizr.js b/app/assets/javascripts/govuk_publishing_components/vendor/modernizr.js
diff --git a/app/views/govuk_publishing_components/components/_layout_for_admin.html.erb b/app/views/govuk_publishing_components/components/_layout_for_admin.html.erb
@@ -18,7 +18,6 @@
     <%= csrf_meta_tags %>
     <%= favicon_link_tag "govuk_publishing_components/favicon-#{environment}.png" %>
     <%= stylesheet_link_tag css_filename, media: "all" %>
-    <%= javascript_include_tag "govuk_publishing_components/vendor/modernizr" %>
     <% if GovukPublishingComponents::Config.use_es6_components %>
       <%= javascript_include_tag js_module_filename, type: "module" %>
     <% end %>

diff --git a/app/views/layouts/govuk_publishing_components/application.html.erb b/app/views/layouts/govuk_publishing_components/application.html.erb
@@ -41,8 +41,6 @@
     <%= stylesheet_link_tag "component_guide/application", media: "all" %>
     <%= yield :application_stylesheet %>
     <%= render_component_stylesheets %>
-
-    <%= javascript_include_tag "govuk_publishing_components/vendor/modernizr" %>
     <%= yield :extra_headers %>
   </head>
   <body class="gem-c-layout-for-admin govuk-template__body <%= 'hide-header-and-footer' if @preview %>">

diff --git a/spec/components/layout_for_admin_spec.rb b/spec/components/layout_for_admin_spec.rb
@@ -18,7 +18,6 @@ def component_name
   end
 
   it "can receive a custom js filename" do
-    allow_any_instance_of(ActionView::Base).to receive(:javascript_include_tag).with("govuk_publishing_components/vendor/modernizr")
     expect_any_instance_of(ActionView::Base).to receive(:javascript_include_tag).with("admin").once
 
     render_component(
@@ -36,7 +35,6 @@ def component_name
     end
 
     it "can receive a custom js filename for es6 " do
-      allow_any_instance_of(ActionView::Base).to receive(:javascript_include_tag).with("govuk_publishing_components/vendor/modernizr")
       allow_any_instance_of(ActionView::Base).to receive(:javascript_include_tag).with("application")
       expect_any_instance_of(ActionView::Base).to receive(:javascript_include_tag).with("es6-bundle", { type: "module" }).once
 
@@ -48,7 +46,6 @@ def component_name
     end
 
     it "can use the default filename for es6 components" do
-      allow_any_instance_of(ActionView::Base).to receive(:javascript_include_tag).with("govuk_publishing_components/vendor/modernizr")
       allow_any_instance_of(ActionView::Base).to receive(:javascript_include_tag).with("application")
       expect_any_instance_of(ActionView::Base).to receive(:javascript_include_tag).with("es6-components", { type: "module" }).once