Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to LUX v4.0.25 #4129

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Upgrade to LUX v4.0.25 #4129

merged 1 commit into from
Aug 6, 2024

Conversation

andysellick
Copy link
Contributor

What

Upgrades LUX/Real User Monitoring to the latest version. See https://github.com/alphagov/govuk_publishing_components/blob/main/docs/real-user-metrics.md#how-to-update-to-a-new-version for more information and the procedure that was followed.

Why

This latest version came out today (?) and we were already one version behind, if we leave it too long to upgrade they stop supporting older versions and this won't work anymore.

Visual Changes

None.

@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4129 August 5, 2024 13:38 Inactive
Copy link
Contributor

@MartinJJones MartinJJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me 👍

I reviewed by installing the lux.js repo and comparing the changes from version 4.0.23 to 4.0.25 and reading the docs.

I couldn't see lux.js available in the repo, I'm happy to take a look at the docs and update them if required.

@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4129 August 6, 2024 10:18 Inactive
@andysellick andysellick merged commit dacaedb into main Aug 6, 2024
12 checks passed
@andysellick andysellick deleted the lux-4.0.25 branch August 6, 2024 10:20
@MartinJJones MartinJJones mentioned this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants