Allow custom name attribute on password input #4238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Signon, we use Devise for authentication. We customise the login screen in order to use the GOV.UK Design System, but in order for everything to work seemlessly with Devise (without undue hacking), we use the default Devise input names of `user[email]` and `user[password]`. Other apps may well have a similar need given that Devise is a pretty standard library This adds support for customising the name of the password input to support such use cases
yndajas
force-pushed
the
custom-name-on-password-input
branch
from
83e33e7 to
5f429f8
Compare
yndajas
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Allow custom name attribute on password input
Why
On Signon, we use Devise for authentication. We customise the login screen in order to use the GOV.UK Design System, but in order for everything to work seemlessly with Devise (without undue hacking), we use the default Devise input names of
user[email]anduser[password]. Other apps may well have a similar need given that Devise is a pretty standard library