-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
**BREAKING** Refactor organisation styles and upgrade to govuk-frontend v5.7.1 #4321
Conversation
b3e77cb
to
3a55af7
Compare
3a55af7
to
694756b
Compare
694756b
to
56ea7aa
Compare
56ea7aa
to
f317385
Compare
f317385
to
6f39e5f
Compare
6f39e5f
to
23c6942
Compare
23c6942
to
0a0a673
Compare
0a0a673
to
777bc3e
Compare
777bc3e
to
5fc6f14
Compare
d2be6e5
to
274b9bb
Compare
274b9bb
to
3323e7f
Compare
3323e7f
to
bec93e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty comprehensive, just a few comments.
app/views/govuk_publishing_components/components/docs/contents_list.yml
Outdated
Show resolved
Hide resolved
236f969
to
e5a1015
Compare
Thanks @andysellick - should be ready for re-review 👍 |
In terms of the two things outlined in your PR description: |
Thanks both 👍 @maxgds will do. Last time we did the Whitehall change ourselves, should we do it ourselves again just to reduce dependency on other teams? alphagov/whitehall#9379 |
That looks a lot easier than I expected it to - yes we should be proactive if we have capacity! |
e5a1015
to
0e54df8
Compare
Excluding no. 10
Share links need to have a black icon with blue links, but the no 10 page needs to retain black links.
govuk-frontend removed the 'and' from their class. We will need to use this temporary mapping class, then change the name in Whitehall, and then remove this class.
0e54df8
to
11b8173
Compare
11b8173
to
a87106c
Compare
Breaking change, as it stops certain colours working on components that are using the
brand
option.`What / Why
.brand__color
class, which was used to give organisations custom link colours fromgovuk-frontend
. However we keep a namespaced.brand__color
style forprime-ministers-office-10-downing-street
, so that links will remain black on the no 10 page only.brand
option from theshare_links
component, and replaces it withblack_icons
andblack_links
. These are needed because the default brand styles are now going to be a black icon with our standard blue links, but the No 10 page needs black links as well, hence needing both options. Onlycollections
used thebrand
variant of this component, so this shouldn't break any other pages. Using these new options incollections
is simple: Update share links branding and update govuk_publishing_components to v45.0.0 collections#3802collections
will be passingbrand:
to the share links component when that is no longer a variant, and organisation components will have abrand__colour
class on them which isn't doing anything now that they all use the default blue colour. These two things may be a backendy thing to resolve, as thebrand
options incollections
seem quite tightly coupled to the backend/models of the org pages.govuk-frontend
fromdepartment-for-science-innovation-and-technology
todepartment-for-science-innovation-technology
( - theand
was dropped.) Ourwhitehall
model still uses the old class name, and therefore renders the page using the old class name, so we need to keep this temporary class in for now. Once we've updatedwhitehall
model to use the new class name, it will grab the styles directly fromgovuk-frontend
allowing us to remove the class in our gem.Testing
static
with this gem. Then runcollections
with this branch: Update share links branding and update govuk_publishing_components to v45.0.0 collections#3802 while pointing at your localstatic
and this version of the gem.Visual Changes
Before
After