Set default font for component guide #4330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catalinailie
approved these changes
Oct 23, 2024
unoduetre
force-pushed
the
2949-the-government-frontend-component-guide-app-examples-dont-have-a-font-set
branch
from
e784874
to
ec57cbb
Compare
AshGDS
approved these changes
Oct 25, 2024
unoduetre
force-pushed
the
2949-the-government-frontend-component-guide-app-examples-dont-have-a-font-set
branch
from
9354c69
to
fc61f4e
Compare
unoduetre
deleted the
2949-the-government-frontend-component-guide-app-examples-dont-have-a-font-set
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Some components do not set their default font, so they do not look right when presented in the component guide, as the component guide does not set the font either. This change fixes this problem by setting the default GDS Transport font for the components guide. By setting it, how the components look in the guide should better reflect how they look in pages, as pages also set the same default font.
This change is only related to component guides and how components look there.
Why
This change was is a way to fix the issues described in this Trello card
Visual Changes
Before
Inverse header preview page:
In government-frontend's component guide:
After
Inverse header preview page:
In government-frontend's component guide: