Add data attributes to summary cards and lists #4331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pezholio
force-pushed
the
add-data-attributes-to-summary-cards-and-lists
branch
from
bd2ce37
to
9b2379f
Compare
pezholio
force-pushed
the
add-data-attributes-to-summary-cards-and-lists
branch
from
9b2379f
to
762080b
Compare
AshGDS
requested changes
Oct 29, 2024
There was a problem hiding this comment.
Code looks good 👍 However we don't do releases within the same pull request. Our process is separate release PRs, and we usually give other devs a heads up in the #govuk-frontenders Slack channel first, in case anyone else wants their changes included in a release.
Therefore, could you rename your changelog entry heading to Unreleased, and remove the Gemfile.lock and version.rb changes?
Thanks 👍
See release docs: https://github.com/alphagov/govuk_publishing_components/blob/main/docs/publishing-to-rubygems.md#publishing-to-rubygems
And an example release PR:
#4338
This allows users to add data attributes (for example, when initialising Javascript modules) to individual rows
This allows users to add data attributes (for example, when initialising Javascript modules) to individual rows
pezholio
force-pushed
the
add-data-attributes-to-summary-cards-and-lists
branch
from
762080b
to
5e3c2e4
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This allows data attributes to be added to summary card and summary list rows
Why
This will allow developers to add Javascript interactivity to individual rows via module initialisation.