Contents list add margin_bottom option #4333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- clean up the template file, reorder and separate the options at the top to make it more readable and remove an unused line - adjust the wording of the documentation intro
maxgds
reviewed
Oct 24, 2024
| @@ -36,6 +35,17 @@ examples: | |||
| text: Second thing | |||
| - href: "#third-thing" | |||
| text: Third thing | |||
| with_bottom_margin: | |||
| description: The component accepts a number for margin bottom from `0` to `9` (`0px` to `60px`) using the [GOV.UK Frontend spacing scale](https://design-system.service.gov.uk/styles/spacing/#the-responsive-spacing-scale). The default big number margin bottom is `20px` (`govuk-spacing(4)`). | |||
There was a problem hiding this comment.
Big number doesn't seem relevant here - copy paste error?
There was a problem hiding this comment.
🤦 thanks, fixed.
maxgds
reviewed
Oct 24, 2024
| assert_select '.gem-c-contents-list.govuk-\!-margin-bottom-4' | ||
| end | ||
|
|
||
| it "applies margin to the component" do |
There was a problem hiding this comment.
maybe make the description more explicit - "applies requested margin to the component" as it reads more like the default option as is.
There was a problem hiding this comment.
No problem, updated.
andysellick
force-pushed
the
contents-list-stuff
branch
from
f7ebd34
to
c3ab4fb
Compare
andysellick
force-pushed
the
contents-list-stuff
branch
from
c3ab4fb
to
819fdb7
Compare
maxgds
approved these changes
Oct 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds the shared helper for margin bottom to the contents list component.
Why
We want to use it somewhere and it needs a different bottom margin.
Visual Changes
None.
Trello card: https://trello.com/c/t0DlqDkW