Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect underline styles on share links #4337

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Fix incorrect underline styles on share links #4337

merged 1 commit into from
Oct 25, 2024

Conversation

AshGDS
Copy link
Contributor

@AshGDS AshGDS commented Oct 24, 2024 •
edited
Loading

What / Why

  • There's a hover underline visual issue when using the flexbox variant.
  • Looks like it was due to main label being a span (meaning it had display: inline).
  • Switching to inline-block seems to have fixed it. This removed the default underline styles, so I reintroduced them via the CSS, which looks better anyway as there's now spacing between the line and the word.
  • Not sure what's going on with the Percy visual change.

Visual Changes

Before

image image

After

image image

@AshGDS AshGDS self-assigned this Oct 24, 2024
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4337 October 24, 2024 15:31 Inactive
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4337 October 24, 2024 15:36 Inactive
@AshGDS AshGDS marked this pull request as ready for review October 24, 2024 15:36
andysellick
andysellick approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@andysellick andysellick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AshGDS AshGDS merged commit 3add4d6 into main Oct 25, 2024
12 checks passed
@AshGDS AshGDS deleted the fix-share-links-underline branch October 25, 2024 08:05
@AshGDS AshGDS mentioned this pull request Oct 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andysellick andysellick andysellick approved these changes

Assignees

@AshGDS AshGDS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AshGDS @andysellick @govuk-ci