Layout super nav header: Correct URL for search form #4341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csutter
force-pushed
the
search-improve
branch
from
4dbebc3
to
4e57c95
Compare
csutter
changed the title
csutter
force-pushed
the
search-improve
branch
from
4e57c95
to
329bb5a
Compare
csutter
added a commit
to alphagov/frontend
that referenced
this pull request
Oct 28, 2024
The form points to the wrong path for search - `/search` is a landing page, not the actual all content finder (which is `/search/all`). This means users searching from the homepage have to go through an unnecessary redirection. Also cleans up the form code by using Rails's tag helper. See also: alphagov/govuk_publishing_components#4341
- Point form at `/search/all` instead of `/search` to avoid most users going through an unnecessary 301 redirect - Use Rails's tag helper for more concise form code (in particular data attributes)
csutter
force-pushed
the
search-improve
branch
from
329bb5a
to
d604f02
Compare
leenagupte
approved these changes
Oct 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
/search/allinstead of/searchto avoid most users going through an unnecessary 301 redirectWhy
Users currently get taken through an additional, unnecessary redirection when performing a search through the layout super nav's search form, as this points to the
/searchlanding page instead of the actual site search page at/search/all. The former will just redirect to the latter if keywords are given:While I was already here, using Rails's tag helper for the form tag means we have more concise and readable data attributes and don't have to manually convert to JSON.