Adjust chart component options #4342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshGDS
approved these changes
Oct 25, 2024
app/views/govuk_publishing_components/components/docs/chart.yml
Outdated
Show resolved
Hide resolved
andysellick
added a commit
to alphagov/frontend
that referenced
this pull request
Oct 25, 2024
- bring the text around charts in a bit, as they're currently colliding with the edge of their containing element when shown inside a card block - this option at time of writing isn't available, will be added in alphagov/govuk_publishing_components#4342
andysellick
force-pushed
the
adjust-chart-options
branch
from
5bfda69
to
69108fc
Compare
- whilst this seemed like a good idea at the time, it presents some issues, notably that the chart has nothing that indicates it is a link and can be clicked on - better to remove the link entirely and provide better guidance on how minimal mode should be used i.e. manage linking to or showing more data at an application level, rather than the component level
andysellick
force-pushed
the
adjust-chart-options
branch
from
69108fc
to
e5b481a
Compare
leenagupte
pushed a commit
to alphagov/frontend
that referenced
this pull request
Oct 25, 2024
- bring the text around charts in a bit, as they're currently colliding with the edge of their containing element when shown inside a card block - this option at time of writing isn't available, will be added in alphagov/govuk_publishing_components#4342
leenagupte
pushed a commit
to alphagov/frontend
that referenced
this pull request
Oct 25, 2024
- bring the text around charts in a bit, as they're currently colliding with the edge of their containing element when shown inside a card block - this option at time of writing isn't available, will be added in alphagov/govuk_publishing_components#4342
leenagupte
pushed a commit
to alphagov/frontend
that referenced
this pull request
Oct 25, 2024
- bring the text around charts in a bit, as they're currently colliding with the edge of their containing element when shown inside a card block - this option at time of writing isn't available, will be added in alphagov/govuk_publishing_components#4342
leenagupte
pushed a commit
to alphagov/frontend
that referenced
this pull request
Oct 25, 2024
- bring the text around charts in a bit, as they're currently colliding with the edge of their containing element when shown inside a card block - this option at time of writing isn't available, will be added in alphagov/govuk_publishing_components#4342
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Change the chart component. Specifically:
Why
For a minimal chart we thought that it should link to a page with more data, but this has proved complicated in an actual page, and now I think it's better handled in an application rather than dictated by the component.
Padding is needed for when the chart is inside an element with a border, as these elements touch the outer edge.
Visual Changes
No change to the minimal version, except that it no longer has a link.
Padded version shown below with the normal version for comparison (it's a bit subtle, look at the left edge).
Trello card: https://trello.com/c/VKrLuGvg