Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use component wrapper on contextual footer #4562

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

AshGDS
Copy link
Contributor

@AshGDS AshGDS commented Jan 16, 2025

What

  • Adds the component wrapper helper to the contextual footer component.

Why

As the trello card states:

Standardising our components to use the component wrapper helper will reduce code, increase standardisation, and improve future feature implementation speed.

Visual changes

None.

@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4562 January 16, 2025 15:53 Inactive
@AshGDS AshGDS force-pushed the contextual-footer-component-wrapper branch from cba8c6a to 3c50578 Compare January 17, 2025 09:44
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4562 January 17, 2025 09:45 Inactive
@AshGDS AshGDS force-pushed the contextual-footer-component-wrapper branch from 3c50578 to 63c3295 Compare January 17, 2025 09:45
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4562 January 17, 2025 09:46 Inactive
@AshGDS AshGDS requested a review from andysellick January 17, 2025 09:50
@AshGDS AshGDS force-pushed the contextual-footer-component-wrapper branch from 63c3295 to 2eccb7a Compare January 17, 2025 15:20
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4562 January 17, 2025 15:20 Inactive
@AshGDS AshGDS merged commit ed0fb44 into main Jan 17, 2025
12 checks passed
@AshGDS AshGDS deleted the contextual-footer-component-wrapper branch January 17, 2025 15:49
unoduetre added a commit that referenced this pull request Jan 22, 2025
* Remove margin top from search component ([PR #4581](#4581))
* **BREAKING** Add component wrapper helper to textarea ([PR #4574](#4574))
* Remove margin top from print link ([PR #4577](#4577))
* **BREAKING** Use component wrapper on print link component  ([PR #4576](#4576))
* Refactor single page notification component ([PR #4501](#4501))
* Remove shared helper from button component ([PR #4569](#4569))
* Remove shared helper from inset text component ([PR #4571](#4571))
* Use component wrapper on contextual footer ([PR #4562](#4562))
* Update Govspeak "Warning Text" component styles ([PR #4487](#4487))
* Make "Add another" component styles more specific ([PR #4579](#4579))
* Translate "and" connective in metadata component to Chinese, Russian and Arabic ([PR #4580](#4580))
@unoduetre unoduetre mentioned this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants