Code

Landline validation#4131

Code

Draft

rparke wants to merge 14 commits intomainalphagov/notifications-api:mainfrom landline-validationalphagov/notifications-api:landline-validationCopy head branch name to clipboard

+34-57

Commits

Commits on Jul 11, 2024

• Refactor our phone validation errors

  Show description for 636ae42
  

  rparke

  authored and

  CrystalPea

  committed
  636ae42

  Copy full SHA for 636ae42

• Remove unused translation of new into old error messages

  Show description for dda7c86
  CrystalPea

  committed
  dda7c86

  Copy full SHA for dda7c86

• Remove legacy comment

  CrystalPea

  committed
  b54e0ca

  Copy full SHA for b54e0ca

• Test for us seeing landlines as valid in our schema

  CrystalPea

  committed
  3a3f9bc

  Copy full SHA for 3a3f9bc

• WIP adding landline validation for feature flagged services

  rparke

  committed
  81c5add

  Copy full SHA for 81c5add

Commits on Jul 12, 2024

• WIP failing tests

  rparke

  committed
  6f99511

  Copy full SHA for 6f99511

Commits on Jul 15, 2024

• WIP

  rparke

  committed
  e3673bf

  Copy full SHA for e3673bf

• tidy up and remove breakpoint

  rparke

  committed
  b2ba67b

  Copy full SHA for b2ba67b

• clean up breakpoints

  rparke

  committed
  1db3435

  Copy full SHA for 1db3435

Commits on Jul 16, 2024

• updated notifications-utils

  rparke

  committed
  0fae179

  Copy full SHA for 0fae179

• updated test to tolerate generic invalid number error (to support move to landlines)

  rparke

  committed
  220e440

  Copy full SHA for 220e440

• fix test param

  rparke

  committed
  f1aa21f

  Copy full SHA for f1aa21f

• updated error

  rparke

  committed
  4ec5270

  Copy full SHA for 4ec5270

• updated test param, invalid international number that wasn't caught before

  rparke

  committed
  ce94a07

  Copy full SHA for ce94a07