PP-11224: Add Dockerfile, config, and unit test workflow #2
Conversation
|
I tried to add otel-config-validator to test the config however....
|
jfharden
force-pushed
the
pp-11224-add-initial-dockerfile
branch
from
a233fae to
a5a4512
Compare
| - uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab | ||
| - name: Docker build | ||
| run: | | ||
| docker build -t pay-adot:github-tests . |
There was a problem hiding this comment.
Should we tag the build with the SHA (like we do on the telegraf tests)?
There was a problem hiding this comment.
I don't think it's needed, we're not actually putting this image anywhere so the tag is completely ephemeral anyway
| "express": "^4.18.2", | ||
| "prom-client": "^14.2.0" | ||
| } | ||
| } |
There was a problem hiding this comment.
Can we add config for these npm packages into dependabot.yml? (The usual open-pull-requests-limit: 0)
There was a problem hiding this comment.
Oh yeah, totally forgot about the npm deps (I wasn't going to have any until the otel config validator didn't work :()
tests/node_service/index.mjs
Outdated
| @@ -0,0 +1,68 @@ | |||
| import { randomUUID } from 'crypto' | |||
There was a problem hiding this comment.
Oh it's not anymore 🤔 I did have it previously and decided it was pointless. I'll remove this
There was a problem hiding this comment.
Been playing around with the tests locally, looks good! I ran into a minor bit of confusion when trying to make the tests fail on purpose, but realised it was because docker-compose hadn't rebuilt the test-app image for me (and I had to delete it manually). In practice I think this will be fine - GHA will not have any cached images lying around.
Yeah I think I will add |
|
@katstevens I've done the couple of updates (removed the unused import, added the docker-compose build). Would you mind re-reviewing? |
Add initial Dockerfile, config, and a workflows to test and tag releases.
You can test this locally by going into the tests/ directory and running
./test.sh(You will need jq installed)