PP-13419 Handle new successful refund notification #5701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcotranchino
force-pushed
the
PP-13419-stop-ingnoring-sent-for-refund
branch
2 times, most recently
from
086fea2 to
06685fb
Compare
marcotranchino
commented
Jan 27, 2025
| } | ||
|
|
||
| if (isRefundTransitionIllegal(oldStatus, newStatus)) { | ||
| logger.error("Notification received for refund [{}] is unexpected and therefore ignored because it would cause an illegal state transition to [{}] as refund is already in state [{}]", |
There was a problem hiding this comment.
We have a separate ticket to handle this scenario and get alerted: [Should] Alert Pay Support in case of illegal state transitions
With this change, we are no longer ignoring the SENT_FOR_REFUND notification sent by Worldpay after a refund submission. The notification is now included in the REFUND_STATUSES and examined: if it contains a RefundAuthorisationReference, then it means that the refund submission was successful, otherwise the notification is ignored. Since we are now processing different types of notifications arriving after a successful refund, we are also introducing a check in the Refund Notification Processor, to avoid setting a refund as successful multiple times, also avoiding multiple emails to the end user. Further information in Jira. https://payments-platform.atlassian.net/browse/PP-13419
marcotranchino
commented
Jan 27, 2025
src/main/java/uk/gov/pay/connector/gateway/worldpay/WorldpayNotificationService.java
Outdated
Show resolved
Hide resolved
marcotranchino
force-pushed
the
PP-13419-stop-ingnoring-sent-for-refund
branch
from
06685fb to
76cbadf
Compare
|
Thank you, @SandorArpa :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, we are no longer ignoring the SENT_FOR_REFUND notification sent by Worldpay after a refund submission.
The notification is now included in the REFUND_STATUSES and examined: if it contains a RefundAuthorisationReference, then it means that the refund submission was successful, otherwise the notification is ignored.
Since we are now processing different types of notifications arriving after a successful refund, we are also introducing a check in the Refund Notification Processor, to avoid setting a refund as successful multiple times, also avoiding multiple emails to the end user.
Further information in Jira.
https://payments-platform.atlassian.net/browse/PP-13419