add unit helper test

app/helpers/navigation_items_helper.rb

@@ -1,17 +1,4 @@
 module NavigationItemsHelper
-	# [
-  #     {
-  #       text: "Publications", href: root_path
-  #     },
-  #   ].concat(current_user.govuk_editor? ? [
-  #     { text: 'Add artefact', href: new_artefact_path },
-  #     { text: 'Downtime', href: downtimes_path }
-  #   ]: []).concat([
-  #     { text: 'Reports', href: reports_path },
-  #     { text: 'Search by user', href: user_search_path },
-  #     { text: 'Sign out', href: '/auth/gds/sign_out' }
-  #   ]
-
 	def navigation_items(is_editor)
 		list = [
 			{ text: "Publications", href: root_path }
@@ -24,6 +11,6 @@ def navigation_items(is_editor)
 
     list << { text: 'Reports', href: reports_path }
     list << { text: 'Search by user', href: user_search_path }
-    list <<  { text: 'Sign out', href: '/auth/gds/sign_out' }
+    list << { text: 'Sign out', href: '/auth/gds/sign_out' }
 	end
 end

test/unit/helpers/naviation_items_helper_test.rb

@@ -0,0 +1,25 @@
+require "test_helper"
+
+class NavigationItemsHelperTest < ActionView::TestCase
+  context "NavigationItemsHelper" do
+  	should "include editor only links when user is an editor" do
+  		assert_equal [
+				{ text: "Publications", href: root_path },
+				{ text: 'Add artefact', href: new_artefact_path },
+				{ text: 'Downtime', href: downtimes_path },
+				{ text: 'Reports', href: reports_path },
+				{ text: 'Search by user', href: user_search_path },
+				{ text: 'Sign out', href: '/auth/gds/sign_out' }				
+			], navigation_items(true)
+  	end
+
+  	should "include not include editor only links when user is not an editor" do
+  		assert_equal [
+				{ text: "Publications", href: root_path },
+				{ text: 'Reports', href: reports_path },
+				{ text: 'Search by user', href: user_search_path },
+				{ text: 'Sign out', href: '/auth/gds/sign_out' }				
+			], navigation_items(false)
+  	end  	
+  end
+end