Skip to content

Commit

Permalink
Fix release version in footer
Browse files Browse the repository at this point in the history
This has been broken since we moved to EKS and the SHA is no longer
provided.

We can use the [SENTRY_RELEASE](https://github.com/alphagov/govuk-helm-charts/blob/077117e7f40c096a958f9e0b853a2bd76cf43f26/charts/generic-govuk-app/templates/deployment.yaml#L92C1-L92C1) environment variable which is defined for every app and takes its value from
the container image's tag.

If for whatever reason the image tag is not defined it will display
`null`, which should make it clearer (instead of displaying `development`)
that this data is not being pulled in successfully.
  • Loading branch information
deborahchua committed Sep 27, 2023
1 parent c6a9630 commit a52a8fd
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 7 deletions.
2 changes: 1 addition & 1 deletion app/views/layouts/application.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
</div>
<% end %>
<% content_for :footer_version, CURRENT_RELEASE_SHA %>
<% content_for :footer_version, ENV.fetch("SENTRY_RELEASE", "null")[0..18] %>
<% content_for :body_end do %>
<%= javascript_include_tag "application" %>
Expand Down
6 changes: 0 additions & 6 deletions config/initializers/current_release_sha.rb

This file was deleted.

0 comments on commit a52a8fd

Please sign in to comment.