Revert "Move metadata functionality to new design system"

This reverts commit 6c49914.

app/assets/stylesheets/application.scss

@@ -23,7 +23,6 @@ $govuk-page-width: 1140px;
 @import 'govuk_publishing_components/components/lead-paragraph';
 @import 'govuk_publishing_components/components/notice';
 @import 'govuk_publishing_components/components/previous-and-next-navigation';
-@import 'govuk_publishing_components/components/radio';
 @import 'govuk_publishing_components/components/search';
 @import 'govuk_publishing_components/components/secondary-navigation';
 @import 'govuk_publishing_components/components/select';

app/controllers/artefacts_controller.rb

@@ -18,26 +18,17 @@ def update
     artefact = Artefact.find(updatable_params[:id])
     if artefact.update_as(current_user, updatable_params)
       UpdateWorker.perform_async(artefact.latest_edition_id)
-      show_success_message
+      flash[:notice] = "Metadata updated"
     else
       flash[:danger] = artefact.errors.full_messages.join("\n")
     end
-
     redirect_to metadata_artefact_path(artefact)
   end
 
   helper_method :formats
 
 private
 
-  def show_success_message
-    if FeatureConstraint.new("design_system_edit")
-      flash[:success] = "Metadata has successfully updated".html_safe
-    else
-      flash[:notice] = "Metadata updated"
-    end
-  end
-
   def formats
     Artefact::FORMATS_BY_DEFAULT_OWNING_APP["publisher"] - Artefact::RETIRED_FORMATS
   end

app/controllers/editions_controller.rb

@@ -1,5 +1,7 @@
+require "edition_duplicator"
+require "edition_progressor"
+
 class EditionsController < InheritedResources::Base
-  include TabbedNavHelper
   layout "design_system"
 
   defaults resource_class: Edition, collection_name: "editions", instance_name: "resource"
@@ -11,11 +13,12 @@ def index
 
   def show
     @artefact = @resource.artefact
-
     render action: "show"
   end
 
-  alias_method :metadata, :show
+  def metadata
+    render action: "show"
+  end
 
   def history
     render action: "show"

app/helpers/tabbed_nav_helper.rb

@@ -1,8 +1,9 @@
 module TabbedNavHelper
   def edition_nav_items(edition)
     nav_items = []
+    items = %w[edit tagging metadata history admin related_external_links unpublish]
 
-    all_tab_names.each do |item|
+    items.each do |item|
       nav_items << standard_nav_items(item, edition)
     end
 
@@ -28,15 +29,4 @@ def edit_nav_item(label, href, current)
       },
     ]
   end
-
-  def current_tab_name
-    current_tab = (request.path.split("/") & all_tab_names).first
-    current_tab == "metadata" ? "metadata" : "temp_nav_text"
-  end
-
-private
-
-  def all_tab_names
-    %w[edit tagging metadata history admin related_external_links unpublish]
-  end
 end

app/views/editions/show.html.erb

@@ -26,8 +26,4 @@
   <div class="govuk-grid-column-full">
     <%= render partial: "secondary_navigation" %>
   </div>
-
-  <div class="govuk-grid-column-two-thirds">
-    <%= render partial: "secondary_nav_tabs/#{current_tab_name}", :locals => { :publication => @resource } %>
-  </div>
 </div>

test/functional/editions_controller_test.rb

@@ -26,14 +26,14 @@ class EditionsControllerTest < ActionController::TestCase
 
   context "#show" do
     setup do
-      artefact = FactoryBot.create(
+      artefact2 = FactoryBot.create(
         :artefact,
         slug: "test2",
         kind: "guide",
         name: "test",
         owning_app: "publisher",
       )
-      @guide = GuideEdition.create!(title: "test", slug: "test2", panopticon_id: artefact.id)
+      @guide = GuideEdition.create!(title: "test", slug: "test2", panopticon_id: artefact2.id)
     end
 
     should "requesting a publication that doesn't exist returns a 404" do
@@ -47,21 +47,4 @@ class EditionsControllerTest < ActionController::TestCase
       assert_not_nil assigns(:resource)
     end
   end
-
-  context "#metadata" do
-    setup do
-      artefact = FactoryBot.create(
-        :artefact,
-        slug: "test2",
-        kind: "guide",
-        name: "test",
-        owning_app: "publisher",
-      )
-      @guide = GuideEdition.create!(title: "test", slug: "test2", panopticon_id: artefact.id)
-    end
-
-    should "alias to show method" do
-      assert EditionsController.new.method(:metadata).super_method.name.eql?(:show)
-    end
-  end
 end

test/integration/edition_edit_test.rb

@@ -6,11 +6,12 @@ class EditionEditTest < IntegrationTest
     test_strategy = Flipflop::FeatureSet.current.test!
     test_strategy.switch!(:design_system_edit, true)
     stub_linkables
-    edition = FactoryBot.create(:guide_edition, title: "Edit page title", state: "draft")
-    visit edition_path(edition)
   end
 
   should "show document summary and title" do
+    edition = FactoryBot.create(:guide_edition, title: "Edit page title", state: "draft")
+    visit edition_path(edition)
+
     assert page.has_title?("Edit page title")
 
     row = find_all(".govuk-summary-list__row")
@@ -23,6 +24,9 @@ class EditionEditTest < IntegrationTest
   end
 
   should "show all the tabs for the edit" do
+    edition = FactoryBot.create(:guide_edition, title: "Edit page title", state: "draft")
+    visit edition_path(edition)
+
     assert page.has_text?("Edit")
     assert page.has_text?("Tagging")
     assert page.has_text?("Metadata")
@@ -31,33 +35,4 @@ class EditionEditTest < IntegrationTest
     assert page.has_text?("Related external links")
     assert page.has_text?("Unpublish")
   end
-
-  context "#metadata" do
-    setup do
-      click_link("Metadata")
-    end
-
-    should "'Metadata' header and an update button" do
-      within :css, ".gem-c-heading" do
-        assert page.has_text?("Metadata")
-      end
-      assert page.has_button?("Update")
-    end
-
-    should "show slug input box prefilled" do
-      assert page.has_text?("Slug")
-      assert page.has_text?("If you change the slug of a published page, the old slug will automatically redirect to the new one.")
-      assert page.has_field?("artefact[slug]", with: /slug/)
-    end
-
-    should "update and show success message" do
-      fill_in "artefact[slug]", with: "changed-slug"
-      choose("Welsh")
-      click_button("Update")
-
-      assert find(".gem-c-radio input[value='cy']").checked?
-      assert page.has_text?("Metadata has successfully updated")
-      assert page.has_field?("artefact[slug]", with: "changed-slug")
-    end
-  end
 end