add all edition reports for content workflow and edition churn #1917
Conversation
- also with additional time and date created fields split from editioned_at to allow for easier data parsing
| @@ -107,7 +153,7 @@ | |||
| "check_name": "Redirect", | |||
| "message": "Possible unprotected redirect", | |||
| "file": "app/controllers/reports_controller.rb", | |||
| "line": 21, | |||
| "line": 25, | |||
There was a problem hiding this comment.
Is it worth keeping these ordered by line number?
There was a problem hiding this comment.
This is autogenerated by brakeman - I suppose we could, but it'll mean constantly fighting against the tool to do it...
There was a problem hiding this comment.
Given it's not really for human consumption I'd prefer to leave it. Thoughts?
| stage | ||
| format | ||
| current_assignee | ||
| created_at |
There was a problem hiding this comment.
Do we need to have date_created and time_created in the initialize function when we have created_at (assuming we keep all 3 in the build_csv method)?
There was a problem hiding this comment.
This was explicitly requested by those who are consuming the data - the better thing to do in my mind would be to remove the created_at field, but I left it in there for consistency with the other reports 🤔
There was a problem hiding this comment.
Just to be overbearingly explicit, the column_headings array in the initialize function need to match perfectly with what we create in the build_csv function (as this all needs to line up properly in the right order on the csv file). So, if we add or remove something from the first array then we need to do the same in the one below, yeah? 😄
Making these changes based on a request by the content improvement team to better understand the rate of change of editions in publisher - they need the historical data, not just that of all current editions, so I'm adding in a couple of extra reports for them.
Follow these steps if you are doing a Rails upgrade.