Log a warning on DocumentNotFound #2259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log a warning when a `Mongoid::Errors::DocumentNotFound` error is raised in a controller. These errors were being silently swallowed by the application. The error occurs when an attempt is made to load a document that doesn't exist, which can happen when the overnight DB replication from prod->integration fails. It will also happen if the edition ID is manipulated in the URL (e.g. in URLs of the form `/editions/[edition-id]`), so it's not _necessarily_ an error when it happens.
mtaylorgds
force-pushed
the
359/log-warning-when-document-not-found
branch
from
15337f3
to
39c461c
Compare
baisa
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log a warning when a
Mongoid::Errors::DocumentNotFounderror is raised in a controller. These errors were being silently swallowed by the application.The error occurs when an attempt is made to load a document that doesn't exist, which can happen when the overnight DB replication from prod->integration fails. It will also happen if the edition ID is manipulated in the URL (e.g. in URLs of the form
/editions/[edition-id]), so it's not necessarily an error when it happens.Example log