Push fact check metrics to prometheus #2269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspired by alphagov/search-api-v2#209 This adds the prometheus-client gem, and then uses it to send fact check emails metrics to prometheus via the pushgateway. We can't use the conventional prometheus collector, because this code runs as a script, rather than a web process. This should not be merged until we've set the PROMETHEUS_PUSHGATEWAY_URL environment variable.
richardTowers
force-pushed
the
custom-prometheus-metrics
branch
from
eca7d59
to
184990d
Compare
The job name should really be the same for all metrics published by this _thing_. We currently have publisher (for the web app) and publisher-worker for the worker. I think publisher-metrics is probably a good job name for these specificly metricsy things.
Tetrino
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by alphagov/search-api-v2#209
This adds the prometheus-client gem, and then uses it to send fact check emails metrics to prometheus via the pushgateway.
We can't use the conventional prometheus collector, because this code runs as a script, rather than a web process.
This should not be merged until we've set the PROMETHEUS_PUSHGATEWAY_URL environment variable.(edit: this is already set automatically for all apps)In terms of testing this, we could probably just deploy this branch to integration, then see whether we can see the new metric in prometheus, then put some broken emails in the inbox (?) and see if the count goes up?
Follow these steps if you are doing a Rails upgrade.