Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document stories and questions around homepage popular links #2270

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

syed-ali-tw
Copy link
Contributor

@syed-ali-tw syed-ali-tw commented Aug 1, 2024

Document stories and questions around homepage popular links

As we moved editing and publishing of 'Popular on GOV.UK' to the Mainstream Publisher, we made certain design and implementation decisions which we have tried to capture through this PR.

Trello

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

Copy link
Contributor

@mtaylorgds mtaylorgds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor grammatical comments.

docs/homepage.md Outdated Show resolved Hide resolved
docs/homepage.md Outdated Show resolved Hide resolved
@syed-ali-tw syed-ali-tw merged commit fa36150 into main Aug 2, 2024
12 checks passed
@syed-ali-tw syed-ali-tw deleted the document-popular-links branch August 2, 2024 14:35

### How to edit popular links

Popular links can be accessed and edited via the 'Homepage' link on Signon, for this we need the 'homepage_editor' permission inside the Mainstream Publisher app.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by comment (found this PR via alphagov/govuk-developer-docs#4763): why was the decision made to expose the 'homepage' functionality of Mainstream Publisher in Signon itself (instead of relying on users to navigate to the functionality via clicking "Publisher")?

It seems a bit of a confusing gotcha to add, unless I'm missing some clear rationale :/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisBAshton This is a product decision about trialing the Signon links as more task-based than app-based. You can chat with our product owner (Emma Carter) if you'd like to learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks for the context - I'll ask Emma 👍 in the meantime it may be useful to add "Why is this being added directly to the Signon landing page?" to the "Questions" section in this doc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ChrisBAshton , we have now updated the doc to add this question.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect - thanks @syed-ali-tw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants