-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document stories and questions around homepage popular links #2270
Conversation
58e6d68
to
bd51078
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor grammatical comments.
bd51078
to
0e51c3f
Compare
0e51c3f
to
84261e0
Compare
|
||
### How to edit popular links | ||
|
||
Popular links can be accessed and edited via the 'Homepage' link on Signon, for this we need the 'homepage_editor' permission inside the Mainstream Publisher app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drive-by comment (found this PR via alphagov/govuk-developer-docs#4763): why was the decision made to expose the 'homepage' functionality of Mainstream Publisher in Signon itself (instead of relying on users to navigate to the functionality via clicking "Publisher")?
It seems a bit of a confusing gotcha to add, unless I'm missing some clear rationale :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChrisBAshton This is a product decision about trialing the Signon links as more task-based than app-based. You can chat with our product owner (Emma Carter) if you'd like to learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thanks for the context - I'll ask Emma 👍 in the meantime it may be useful to add "Why is this being added directly to the Signon landing page?" to the "Questions" section in this doc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ChrisBAshton , we have now updated the doc to add this question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect - thanks @syed-ali-tw
Document stories and questions around homepage popular links
As we moved editing and publishing of 'Popular on GOV.UK' to the Mainstream Publisher, we made certain design and implementation decisions which we have tried to capture through this PR.
Trello
Follow these steps if you are doing a Rails upgrade.