-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Popular links delete #2276
Popular links delete #2276
Commits on Aug 8, 2024
-
Outline for destroy method and link
Add delete functionality and confirm destroy method Functional and integration tests added for delete mechanism Routes for 'confirm delete' page and actual destroy action
Configuration menu - View commit details
-
Copy full SHA for 30c8e11 - Browse repository at this point
Copy the full SHA 30c8e11View commit details -
Confirmation page created - removed delete page and links
Destroy and confirm destroy functionality PopularLinksEdition.can_delete? method to test if edition can be deleted Tests for confirmation page and cancel delete
Configuration menu - View commit details
-
Copy full SHA for 833943a - Browse repository at this point
Copy the full SHA 833943aView commit details -
Destroy tests added and extracted error message out
Tests for: Show previously published edition Successful and unsuccessful delete from DB Application error message was being used twice, so extracted out to own method.
Configuration menu - View commit details
-
Copy full SHA for 256da1b - Browse repository at this point
Copy the full SHA 256da1bView commit details -
Add check if the edition can be deleted before deletion
Added an extra check to ensure that there is no way to delete a published edition. To prevent issues with multiple users accessing the same edition.
Configuration menu - View commit details
-
Copy full SHA for 8445f5c - Browse repository at this point
Copy the full SHA 8445f5cView commit details -
Desk check changes - messages and labels made more consistent
Link renamed to 'Delete draft' Application error message makes it clear that it was a draft that failed to be deleted not an edition 'Can't delete published edition' message updated to be more helpful Confirmation and success messages reworded to be clear it is a draft that will be/has been deleted
Configuration menu - View commit details
-
Copy full SHA for 87a1eaf - Browse repository at this point
Copy the full SHA 87a1eafView commit details
Commits on Aug 12, 2024
-
PR Quick fixes, test title, removed incorrect content block and renam…
…e of error message method Fixed incorrect test title Fixup! Add missing test and extracted error message method Rename of error message method Removed content block that doesn't exist in mainstream
Configuration menu - View commit details
-
Copy full SHA for f0d6ace - Browse repository at this point
Copy the full SHA f0d6aceView commit details
Commits on Aug 13, 2024
-
PR - Test improvements and fixes
Improved test - more descriptive name and added assert for the error message Test improvements - more accurate names and extra assert Renamed tests to more explanatory names Added test to check alert and redirect if delete from DB fails with an exception Divided tests into 3 contexts - 'draft', 'published' and 'database errors' Moved context blocks 'destroy' and 'confirm destroy' to after 'publish' Moved the test for deletion failure to #destroy #draft context block Added redirect assert to test for can't delete published edition
Configuration menu - View commit details
-
Copy full SHA for 1681ad9 - Browse repository at this point
Copy the full SHA 1681ad9View commit details