-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update doc to explain 'Why is this being added directly to the Signon' #2279
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of minor comments.
docs/homepage.md
Outdated
@@ -23,6 +23,12 @@ We do not store the secrets generated by this command and just rely on the secre | |||
|
|||
### Questions | |||
|
|||
#### Why is this being added directly to the Signon landing page and via Publisher? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be "not via Publisher"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant to add and 'permissions via Publisher' but I think it has already been adressed so I will just keep it as Chris asked i.e. "Why is this being added directly to the Signon?"
docs/homepage.md
Outdated
#### Why is this being added directly to the Signon landing page and via Publisher? | ||
|
||
The functionality itself will sit within Mainstream Publisher. However, we’ve made the decision to take an experimental approach and show the Homepage link within the main signon page. | ||
We’ve decided to trial this as we believe that users should simply be able to select what action they want to perform, rather than having to understand what app they need to use to accomplish a task. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want these to be separate paragraphs, I think we need to add a blank line in the source code, otherwise they will all be rendered as a single paragraph.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keeping it as one paragraph
22677d0
to
c54c18e
Compare
c54c18e
to
2e1cd26
Compare
Update popular links doc to answer why Homepage is being added directly to the Signon landing page
Follow these steps if you are doing a Rails upgrade.