Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

321 upgrade publications page table #2284

Merged
merged 1 commit into from
Aug 22, 2024
Merged

321 upgrade publications page table #2284

merged 1 commit into from
Aug 22, 2024

Conversation

davidtrussler
Copy link
Contributor

Trello

These changes add the new table, using the Design System, to the Publications page. This is only rendered with the Design System flag. There is still work to do on this featrure that will be covered in later PRs:

  • complete the tests for the new table
  • update the layout to deal with some problems that became apparent once it is in place
Current Design System
Screenshot 2024-08-15 at 13 13 22 Screenshot 2024-08-15 at 13 13 54

@davidtrussler davidtrussler force-pushed the 321_Upgrade-Publications-page-table branch from 69ada95 to 0e736ee Compare August 15, 2024 12:25
mtaylorgds
mtaylorgds reviewed Aug 15, 2024
View reviewed changes
Copy link
Contributor

@mtaylorgds mtaylorgds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments.

app/assets/javascripts/modules/publisher-table.js Outdated Show resolved Hide resolved
spec/javascripts/spec/publisher_table.spec.js Outdated Show resolved Hide resolved
spec/javascripts/spec/publisher_table.spec.js Outdated Show resolved Hide resolved
spec/javascripts/spec/publisher_table.spec.js Outdated Show resolved Hide resolved
app/assets/javascripts/modules/publisher-table.js Outdated Show resolved Hide resolved
app/helpers/publications_table_helper.rb Outdated Show resolved Hide resolved
@davidtrussler davidtrussler force-pushed the 321_Upgrade-Publications-page-table branch 2 times, most recently from 419f02c to 83128f0 Compare August 15, 2024 15:11
mtaylorgds
mtaylorgds reviewed Aug 16, 2024
View reviewed changes
test/unit/helpers/admin/publications_table_helper_test.rb Show resolved Hide resolved
app/helpers/publications_table_helper.rb Outdated Show resolved Hide resolved
test/unit/helpers/admin/publications_table_helper_test.rb Outdated Show resolved Hide resolved
test/unit/helpers/admin/publications_table_helper_test.rb Outdated Show resolved Hide resolved
test/unit/helpers/admin/publications_table_helper_test.rb Outdated Show resolved Hide resolved
test/unit/helpers/admin/publications_table_helper_test.rb Outdated Show resolved Hide resolved
test/unit/helpers/admin/publications_table_helper_test.rb Show resolved Hide resolved
test/unit/helpers/admin/publications_table_helper_test.rb Outdated Show resolved Hide resolved
test/unit/helpers/admin/publications_table_helper_test.rb Outdated Show resolved Hide resolved
test/unit/helpers/admin/publications_table_helper_test.rb Show resolved Hide resolved
@davidtrussler davidtrussler force-pushed the 321_Upgrade-Publications-page-table branch 8 times, most recently from cb20a56 to f65bc5e Compare August 21, 2024 13:31
@davidtrussler davidtrussler force-pushed the 321_Upgrade-Publications-page-table branch 4 times, most recently from 73de236 to c5909a3 Compare August 21, 2024 17:52
mtaylorgds
mtaylorgds requested changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@mtaylorgds mtaylorgds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're going to need to implement pagination before merging this PR—I tried it locally, with a copy of integration data, and it took over 9m for the app to return a response (and the browser gave up waiting after about 3m).

spec/javascripts/spec/publications_table.spec.js Outdated Show resolved Hide resolved
test/unit/helpers/admin/publications_table_helper_test.rb Outdated Show resolved Hide resolved
mtaylorgds
mtaylorgds approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@mtaylorgds mtaylorgds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidtrussler davidtrussler force-pushed the 321_Upgrade-Publications-page-table branch from df1c399 to a936f7f Compare August 22, 2024 13:15
@davidtrussler davidtrussler merged commit 871c21d into main Aug 22, 2024
13 checks passed
@davidtrussler davidtrussler deleted the 321_Upgrade-Publications-page-table branch August 22, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtaylorgds mtaylorgds mtaylorgds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidtrussler @mtaylorgds