205 filter publications UI #2301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidtrussler
force-pushed
the
205_filter-publications_UI
branch
from
9b2b5ae
to
4ffca44
Compare
mtaylorgds
reviewed
Aug 27, 2024
app/views/root/_filter.html.erb
Outdated
| } %> | ||
|
|
||
| <%= render "govuk_publishing_components/components/select", { | ||
| id: "format_filter", |
There was a problem hiding this comment.
Maybe now would be a good time to rename the various usages of the term "format" with "content type" in the new (non-legacy) code.
davidtrussler
force-pushed
the
205_filter-publications_UI
branch
from
4536ae5
to
c5d653c
Compare
|
With this PR, we should probably port all the tests in |
davidtrussler
force-pushed
the
205_filter-publications_UI
branch
3 times, most recently
from
eb83beb
to
1d7a41a
Compare
davidtrussler
force-pushed
the
205_filter-publications_UI
branch
7 times, most recently
from
995eb29
to
b23a112
Compare
mtaylorgds
reviewed
Sep 5, 2024
syed-ali-tw
approved these changes
Sep 5, 2024
davidtrussler
force-pushed
the
205_filter-publications_UI
branch
from
f1623b4
to
a998a8f
Compare
- Add stylesheet for Publications page - Add publishing components to filter form - Add new tests and update existing tests
davidtrussler
force-pushed
the
205_filter-publications_UI
branch
from
a998a8f
to
a814f65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello
This work primarily adds the UI to the filter section of the publications page into the left hand column (see screenshot below).
In addition to that there is some logic to pre-populate fields where required which could probably do with a bit more discussion form a Rails perspective.