205 filter publications UI root overview tests #2315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidtrussler
force-pushed
the
205_filter-publications_UI_root-overview-tests
branch
3 times, most recently
from
ec71432
to
02afa04
Compare
davidtrussler
force-pushed
the
205_filter-publications_UI_root-overview-tests
branch
from
02afa04
to
5366f24
Compare
syed-ali-tw
reviewed
Sep 12, 2024
syed-ali-tw
reviewed
Sep 12, 2024
davidtrussler
force-pushed
the
205_filter-publications_UI_root-overview-tests
branch
from
5366f24
to
8f71669
Compare
|
LGTM |
syed-ali-tw
approved these changes
Sep 13, 2024
… system: - filter by assigned user - filter by title contenit - not lose the active section when filtering by title content - filter by content type - not break archived view when invalid sibling_in_progress - not show disabled users in 'Assignee' select box - display publications in review correctly ordered - allow a user to claim 2i - prevent claiming 2i when someone else has - prevent the assignee claiming 2i - allow Welsh editors to see claim 2i button in Welsh editions - not allow Welsh editors to see claim 2i button in non-Welsh editions - not render popular links edition
davidtrussler
force-pushed
the
205_filter-publications_UI_root-overview-tests
branch
from
5b22e04
to
1249ca2
Compare
davidtrussler
deleted the
205_filter-publications_UI_root-overview-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello
The changes in this PR add a number of tests from the legacy Publications page and refactors them for the new Design System UI. The tests are based on the legacy tests in
/test/integration/legacy_root_overview_test.rb.Some legacy tests have not been ported to the Design System as they raise a number of issues about changed or missing functionality that will be dealt with separately. Details of these are in the Trello card.