require prometheus client libs in mail_fetcher #2327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is job is currently erroring in all environments, albeit after it's
already done all the important work.
{"@timestamp":"2024-09-16T13:05:05.605Z","message":"Finished running MailFetcher in production mode - 2024-09-16 13:05:05 UTC","level":"INFO","tags":["rails"]}
script/mail_fetcher:58:in `<main>': uninitialized constant Prometheus::Client::Push (NameError)
Prometheus::Client::Push.new(
Note the "Finished running MailFetcher in production mode" log before the error
- the script has still done everything it needs to, it just hasn't sent the
metrics, which fortunately is on the very last line of the script.
This looks like the same mistake I made when doing metrics for publishing-api:
alphagov/publishing-api@3037457
We need to explicitly require the push library to use it. I'm not 100% sure if
we really need the other two imports (client and registry), but publishing-api
has them, so we may as well be consistent. Can't hurt, surely.
Tetrino
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is job is currently erroring in all environments, albeit after it's already done all the important work.
Note the "Finished running MailFetcher in production mode" log before the error
This looks like the same mistake I made when doing metrics for publishing-api:
We need to explicitly require the push library to use it. I'm not 100% sure if we really need the other two imports (client and registry), but publishing-api has them, so we may as well be consistent. Can't hurt, surely.
Follow these steps if you are doing a Rails upgrade.