425 metadata tab edit page #2338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syed-ali-tw
force-pushed
the
425-metadata-tab-edit-page
branch
5 times, most recently
from
b03df60
to
fa994b5
Compare
davidtrussler
force-pushed
the
425-metadata-tab-edit-page
branch
from
2aec29b
to
b9ef490
Compare
syed-ali-tw
force-pushed
the
425-metadata-tab-edit-page
branch
3 times, most recently
from
9d7ad89
to
384856f
Compare
mtaylorgds
reviewed
Sep 24, 2024
There was a problem hiding this comment.
This could be done in a subsequent PR (as part of the same story), but the validation needs work—there should be inline validation messages, and the message at the top should be more readable, and should be in an error summary, with links to the appropriate field.
I thought we were transitioning by content type—so you would only see the design system tabs for help pages and answers, but would still see the old bootstrap UI for other content types—has this changed?
Is there any test coverage for the validation messages?
syed-ali-tw
force-pushed
the
425-metadata-tab-edit-page
branch
5 times, most recently
from
13c9bca
to
7a86066
Compare
mtaylorgds
reviewed
Sep 24, 2024
Add success message on update
syed-ali-tw
force-pushed
the
425-metadata-tab-edit-page
branch
3 times, most recently
from
3130caa
to
8fb9944
Compare
mtaylorgds
reviewed
Sep 25, 2024
syed-ali-tw
force-pushed
the
425-metadata-tab-edit-page
branch
2 times, most recently
from
893fa22
to
f753276
Compare
syed-ali-tw
force-pushed
the
425-metadata-tab-edit-page
branch
from
f753276
to
f44bbf0
Compare
mtaylorgds
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello
Move Metadata tab to new design system