454 customise select2 styles #2350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidtrussler
force-pushed
the
454_Customise-select2-styles
branch
from
4adde29
to
d3e0c58
Compare
mtaylorgds
reviewed
Oct 1, 2024
davidtrussler
force-pushed
the
454_Customise-select2-styles
branch
from
d3e0c58
to
89bb80e
Compare
- navbar crown missing - select2 dropdown: remove and arrow icons - select2 search bar: search icon and gradients - select2 search bar (active state): spinner icon - select2 styles on low resolution devices - select2 more results (not used in Publisher) - select2 multi container (not used in Publisher) - select2 search choice close (not used in Publisher)
davidtrussler
force-pushed
the
454_Customise-select2-styles
branch
from
89bb80e
to
8f83bcc
Compare
mtaylorgds
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello
These changes add a number of over-ride styles to existing bootstrap styles that became necessary after the upgrade to Dart Sass.
The need for these became evident in the request receive to fix a problem that became evident after that upgrade (detailed in the Trello card), concerning the user's ability to remove a selection from a dropdown selector. Upon closer inspection it became apparent that a number of other over-ride styles were required to restore some instances of broken UI as follows (see screenshots below):
There are some styles added specifically for the display of right-to-left languages.
In addition some over-rides have been added for the Select2 element that are not used in this app but are present for completeness and potential future use.